Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix idle timeout issue #26

Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix idle timeout issue #26

merged 1 commit into from
Apr 16, 2019

Commits on Apr 13, 2019

  1. fix idle timeout issue 

    details of bug are here: nodejs/node#13391
docs here: https://nodejs.org/dist/latest-v8.x/docs/api/http.html#http_server_keepalivetimeout

tl;dr is node set a 5s idle timeout. this does what go and java both seem to
do (have not checked python or ruby, though from what I know about python,
we are not doing this either) and doesn't have an idle timeout. since in this
case we do kinda trust that the client is using an idle timeout (it's fn),
this seems like the right policy anyway (if fn dies is something to consider,
but the least of our worries is fdk conns in that case, and we are killing fn
spawned containers on startup too). it should also be noted the client (fn) is
only using 1 conn per container.
    @rdallman
    rdallman committed Apr 13, 2019
    Configuration menu
    Copy the full SHA
    05e4001 View commit details
    Browse the repository at this point in the history