fn: test and release scripts now run some jobs in background #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinowski
force-pushed
the
gofmt_tweak
branch
from
e9aebe2
to
9d0962c
Compare
skinowski
force-pushed
the
gofmt_tweak
branch
from
9d0962c
to
ff0354e
Compare
|
Not sure how I feel about this change myself due to the mess it introduces into shell scripts, but it does speed things a bit. |
|
ehhh, not sure how I feel about it either. Maybe we can wait until CI gets way out of control before we start adding this? Also, Circle supports parallel steps that might make it easier to grok when trying to figure out where something went wrong: https://circleci.com/docs/2.0/parallelism-faster-jobs/ |
| PID3=$! | ||
|
|
||
| # pull swagger image | ||
| (docker pull quay.io/goswagger/swagger ) & |
There was a problem hiding this comment.
see my comments at related issue, this image huge, why not just download binary for releases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.