Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TransactionalDispatcher extend EventDispatcher #15

Merged
merged 2 commits into from
Sep 21, 2018

Conversation

Hanson
Copy link
Contributor

@Hanson Hanson commented Aug 24, 2018

That's some problem when I use TransactionalDispatcher And Sentry both.

https://github.com/getsentry/sentry-laravel/blob/master/src/Sentry/SentryLaravel/SentryLaravelEventHandler.php#L72

SentryLaravelEventHandler::handle(Dispatcher $dipatch) require a Dispatcher but got a TransactionalDispatcher, to work perferlly TransactionalDispatcher can extends Dispatch

@fntneves
Copy link
Owner

Hi @Hanson,

Thank you for opening this PR.

Could you please tell me which version of Sentry and Laravel are you using?
I've noticed before this was a problem, but Sentry fixed it by changing the method's signature to the Dispatcher interface. See getsentry/sentry-laravel#107

@Hanson Hanson closed this Aug 24, 2018
@Hanson
Copy link
Contributor Author

Hanson commented Aug 24, 2018

My sentry's version was too old, obviously that's no longer a problem, thanks

@fntneves fntneves mentioned this pull request Sep 21, 2018
@fntneves fntneves reopened this Sep 21, 2018
@fntneves fntneves changed the title Make TransactionalDispatcher work with Senrtry Make TransactionalDispatcher extend EventDispatcher Sep 21, 2018
@fntneves
Copy link
Owner

@Hanson I will merge this out, there all many repositories with this problem. Thank you for your contribution.

@fntneves fntneves merged commit af0dac5 into fntneves:master Sep 21, 2018
fntneves added a commit that referenced this pull request Sep 26, 2018
fntneves added a commit that referenced this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants