-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jest to v29 #1271
Update Jest to v29 #1271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
I tested it locally and the only issue I have found is that if I run the tests from the root via yarn test
, the command ends (successfully) before the tests are fully run. This doesn't happen with Jest 27.
This doesn't happen in CI as the --stream
flag is being passed, and I tested locally that by passing the flag is issue is resolved too.
I have also verified that instead when running yarn test
from within the foam-vscode
package the behavior is correct (that is, the tests all run before the command returns)
Adding the --stream
flag to the root package.json test
script seems to fix the problem:
"test": "yarn workspace foam-vscode test --stream",
What does that |
The issue seems to be in the way I can't find anything specific on the yarn documentation for the Keep in mind that we have a very old version of For the sake of this PR I am happy by simply adding |
Without `--stream` in the workspace package, the command ends successfully without correctly running the tests.
@allcontributors add @nicholas-l for code |
I've put up a pull request to add @nicholas-l! 🎉 |
This updates to the latest Jest version.
Note: I haven't been able run tests (either master or this branch) locally as I believe it is due to Arm issues.