-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(display): add progress #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foamzou
requested changes
Aug 24, 2022
utils/wget.go
Outdated
@@ -43,8 +57,12 @@ func WgetBinary(url string, downloadTo string, headers map[string]string) error | |||
if len(resp.Header["Content-Type"]) > 0 && strings.Contains(resp.Header["Content-Type"][0], "text") { | |||
return errors.New("target is not a binary") | |||
} | |||
|
|||
_, err = io.Copy(out, resp.Body) | |||
reader := &ProgressReader{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面的 DownloadBinaryWithTCP 可以顺便支持一下吗?这样就统一了
mar-heaven
force-pushed
the
main
branch
3 times, most recently
from
August 24, 2022 15:38
8a3976f
to
1a4d537
Compare
Http的progress已经改了,TCP把第一个包解析一下?
Ginta
***@***.***
…------------------ 原始邮件 ------------------
发件人: "foamzou/media-get" ***@***.***>;
发送时间: 2022年8月24日(星期三) 中午12:37
***@***.***>;
***@***.******@***.***>;
主题: Re: [foamzou/media-get] feat(display): add progress (PR #6)
@foamzou requested changes on this pull request.
In utils/wget.go:
> @@ -12,6 +12,20 @@ import ( "strings" ) +type ProgressReader struct { + io.Reader + Total int64 + Current int64 +} + +func (r *ProgressReader) Read(p []byte) (n int, err error) { + n, err = r.Reader.Read(p) + + r.Current += int64(n) + fmt.Printf("\rdownloading percent: %.2f%%", float64(r.Current*10000/r.Total)/100)
这里使用本 repo 的 logger 库去打印,避免 silence level 下也会污染 stdout ,导致使用方解析数据失败
In utils/wget.go:
> @@ -43,8 +57,12 @@ func WgetBinary(url string, downloadTo string, headers map[string]string) error if len(resp.Header["Content-Type"]) > 0 && strings.Contains(resp.Header["Content-Type"][0], "text") { return errors.New("target is not a binary") } - - _, err = io.Copy(out, resp.Body) + reader := &ProgressReader{
下面的 DownloadBinaryWithTCP 可以顺便支持一下吗?这样就统一了
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
foamzou
reviewed
Aug 24, 2022
Thanks bro @mar-heaven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.