Fix missing paging on all models #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are more instances than will fit in a page a next_page_token is returned. This has to be passed in to subsequent calls in order to retrieve the full list of servers.
agrare
force-pushed
the
fix_all_paging
branch
2 times, most recently
from
a1bc342 to
295766e
Compare
Most of the models' `#all` methods are missing paging which limits the number of results to a maximum of 500.
agrare
changed the title
1 task
Temikus
approved these changes
Oct 29, 2023
|
Thanks @Temikus ! |
|
Hey @Temikus! Unless you have bigger plans for master I wonder if you could cut a patch release that includes this fix? |
|
@agrare of course, will do today. Apologies for the delay - I got sick with really bad bronchitis, only just recovered. |
|
Oh no! Glad you're feeling better @Temikus thanks so much |
agrare
added a commit
to agrare/manageiq-providers-google
that referenced
this pull request
Dec 2, 2023
Update fog-google to 1.23.0 to pull in fog/fog-google#609
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.