-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kwargs ArgumentError on ruby3 #156
Conversation
``` [ArgumentError]: wrong number of arguments (given 3, expected 1..2) /home/grare/adam/.gem/ruby/3.1.0/gems/kubeclient-4.12.0/lib/kubeclient.rb:22:in `initialize' ```
NOTE this was actually failing specs but I don't see any CI running for this repository, looks like it used travis and never switched to github actions. I'm happy to contribute some GHA workflows for running tests but will likely need a maintainer to help with repo settings. |
Hi @agrare! It is great seeing you again :-) |
@masayag ! How are you doing? Thanks for the quick reply I'll get a simple GHA workflow running in my fork and then push a PR so we can get some specs running on this change |
Thank you, @agrare. |
Thanks for the merge @masayag ! Could I trouble you for a gem release 🙇 |
As I said before, haven't worked with this for several good years. In my recent laptop installation (>1yrs ago) I haven't installed ruby/gem... I'd be happy to add you as an owner for the gem if you provide my your rubygem handler. |
Yeah I'd be happy to help, I'm https://rubygems.org/profiles/agrare |
Done, pls approve the request. |
Related:
Fixes #155