Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kwargs ArgumentError on ruby3 #156

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

agrare
Copy link
Collaborator

@agrare agrare commented Jul 22, 2024

[ArgumentError]: wrong number of arguments (given 3, expected 1..2)
/home/grare/adam/.gem/ruby/3.1.0/gems/kubeclient-4.12.0/lib/kubeclient.rb:22:in `initialize'

Related:

Fixes #155

```
[ArgumentError]: wrong number of arguments (given 3, expected 1..2)
/home/grare/adam/.gem/ruby/3.1.0/gems/kubeclient-4.12.0/lib/kubeclient.rb:22:in `initialize'
```
@agrare
Copy link
Collaborator Author

agrare commented Jul 22, 2024

NOTE this was actually failing specs but I don't see any CI running for this repository, looks like it used travis and never switched to github actions. I'm happy to contribute some GHA workflows for running tests but will likely need a maintainer to help with repo settings.

@masayag
Copy link
Collaborator

masayag commented Jul 22, 2024

NOTE this was actually failing specs but I don't see any CI running for this repository, looks like it used travis and never switched to github actions. I'm happy to contribute some GHA workflows for running tests but will likely need a maintainer to help with repo settings.

Hi @agrare! It is great seeing you again :-)
Although I have rights to approve and merge PR, I haven't worked on this project (or any RoR project TBH) for several good years.
I'd be happy to assist as I can in settings this project to your recommendation (and according to the permissions I have)

@agrare
Copy link
Collaborator Author

agrare commented Jul 22, 2024

@masayag ! How are you doing? Thanks for the quick reply I'll get a simple GHA workflow running in my fork and then push a PR so we can get some specs running on this change

@masayag masayag closed this Jul 22, 2024
@masayag masayag reopened this Jul 22, 2024
@masayag masayag merged commit a77c2e2 into fog:master Jul 22, 2024
1 check passed
@agrare agrare deleted the fix_ruby_3_kubeclient_kwargs_error branch July 22, 2024 17:17
@masayag
Copy link
Collaborator

masayag commented Jul 22, 2024

Thank you, @agrare.

@agrare
Copy link
Collaborator Author

agrare commented Jul 22, 2024

Thanks for the merge @masayag !

Could I trouble you for a gem release 🙇

@masayag
Copy link
Collaborator

masayag commented Jul 22, 2024

Thanks for the merge @masayag !

Could I trouble you for a gem release 🙇

As I said before, haven't worked with this for several good years. In my recent laptop installation (>1yrs ago) I haven't installed ruby/gem...

I'd be happy to add you as an owner for the gem if you provide my your rubygem handler.

@agrare
Copy link
Collaborator Author

agrare commented Jul 22, 2024

Yeah I'd be happy to help, I'm https://rubygems.org/profiles/agrare

@masayag
Copy link
Collaborator

masayag commented Jul 22, 2024

Done, pls approve the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubeclient kwargs failure with ruby 3
2 participants