Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gemfile and gemspec to gem build files so rpm can be built. #303

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add Gemfile and gemspec to gem build files so rpm can be built. #303

merged 1 commit into from
Jul 15, 2024

Conversation

chris1984
Copy link
Collaborator

No description provided.

@chris1984 chris1984 merged commit 76aac4f into master Jul 15, 2024
3 of 5 checks passed
@ekohl
Copy link
Contributor

ekohl commented Jul 31, 2024

I only see this now, but you do not need them for RPMs to build. Instead what should have been done is to drop them from the %files section in the spec. You're effectively reverting 4a7f4e7.

@chris1984
Copy link
Collaborator Author

I only see this now, but you do not need them for RPMs to build. Instead what should have been done is to drop them from the %files section in the spec. You're effectively reverting 4a7f4e7.

Ok I will make a PR to fix this, that was my fault sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris1984 @ekohl