added support for Visual Studio 2013 #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,10 @@ | |||
| #ifndef _client_h_ | |||
| #define _client_h_ | |||
|
|
|||
| #ifdef _MSC_VER | |||
| #define snprintf _snprintf | |||
| #endif | |||
There was a problem hiding this comment.
Do we want to define this in the headers, or in the C files?
There was a problem hiding this comment.
Either one. I chose the header files because it makes for fewer overall edits. auth.c, client.c, and main.c all use this function.
satoshinm
added a commit
to satoshinm/NetCraft
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual Studio 2013 has C99 support which allows Craft to be built successfully using the MSVC compiler. The only requirement, besides updating the Cmake file, is that
snprintfapparently exists as_snprintfin MSVC's C compiler, so you can just#defineit.