Auth NPE on favs and favorite ownership #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the erroneous assumption that users can only favorite their owned objects. And that users can only favorite recipes. And leave the door open for getting other's favorites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kickstart services a query, not only data loading may be spread across several threads, field resolving may too. So can't rely on Spring Security's context holder in resolvers. This hasn't been a problem so far, but suggesting recipes (at least when paired with library search) sometimes does - #100 - when resolving favorites.
Resolving favorites was coded with the assumption that user can only favorite their own recipes - #101 - which is inaccurate. The favorites field is not used by the UI, even though it's often queried for. Rather, it queries for favorites separately and does the join client-side.
closes #100 and #101.