Save recipe graphql #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using Spring's MultipartFile directly, wrap it with an Upload type of our own, and use that for all the storage. Currently, that's recipes and textract. This is to facilitate supporting the same actions from GraphQL, which speaks Servlet API (no Spring). Along the way, get rid of IOException, since we always wrap and rethrow anyway. For similar reasons, move the recipe photo upload handling out of the controller and down into the service layer.
The S3 client ends up closing the stream, but doesn't guarantee that it will. In fact, it takes care to put the original stream back (after replacing it with its digest-y one) for the caller to close as needed. Be safe and do it explicitly; it's just a no-op if it happens twice.
barneyb
force-pushed
the
save-recipe-graphql
branch
from
a040ee9 to
8c87107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support create/update/deleted of recipes via graphql