Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when a recipe isn't found #26

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Throw an error when a recipe isn't found #26

merged 2 commits into from
Feb 1, 2024

Conversation

switzerb
Copy link
Contributor

In reference to folded-ear/gobrennas-client#71 -- the 404 will only show now when an explicit error is thrown from the API. This PR adds a NoResultException which will trigger the 404 in the client.

@switzerb switzerb requested a review from barneyb January 29, 2024 03:51
barneyb
barneyb approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@barneyb barneyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good opportunity to write the first test for LibraryQuery?

@switzerb
Copy link
Contributor Author

Might be a good opportunity to write the first test for LibraryQuery?

I LIKE IT.

@switzerb switzerb merged commit bb82387 into master Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneyb barneyb barneyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@switzerb @barneyb