Support item recognition via the GraphQL API #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardize on "quantity" and remove "amount". Move RecognizedItem's nested types to the top level, and apply a bunch of lombok. Separate RecognizedRange values into id and quantity buckets, so they can be separately typed.
Production code must specify values for all knobs, nothing implicit.
barneyb
force-pushed
the
recog-graphql
branch
from
632a5a6 to
91bffb7
Compare
barneyb
force-pushed
the
recog-graphql
branch
from
91bffb7 to
ee97d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new field to
LibraryQueryfor recognizing an item. Finish standardizing on "quantity" (not "amount"). MoveRecognizedItem's nested types to the top level, to simplify java-graphql-kickstart configuration, as more of it can be done by auto-configuration. Split suggestion generation from the main item recognition, as GraphQL offers a way to talk about the two parts separately.