[MODINVOICE-554]. Invoices app: Incorrect formula for calculating adjustments, that are included and pro-rated by amount #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustments, that are included and pro-rated by amount
BKadirkhodjaev
commented
Oct 14, 2024
| """ | ||
| * table invoices | ||
| | id | invoiceId | currency | adjustments | | ||
| | invoiceId1 | invoiceId1 | 'EUR' | invoiceAdjustments | |
There was a problem hiding this comment.
Two invoices used, first invoice is used to verify the logic for a simple single-line case, while the second invoice for cases with multiple invoice lines being added and/or removed. Both cases should not affect other invoice line adjustments.
SerhiiNosko
approved these changes
Oct 14, 2024
azizbekxm
approved these changes
Oct 14, 2024
This was referenced Oct 14, 2024
[MODINVOICE-554-2]. Change invoice total and adjustments total calculation
folio-org/mod-invoice#512
Merged
BKadirkhodjaev
added a commit
that referenced
this pull request
Oct 22, 2024
* Revert "[MODINVOICE-554-2]. Change invoice total and adjustments total calculation (#1565)" This reverts commit 32b593c. * Revert "[MODINVOICE-554]. Invoices app: Incorrect formula for calculating adjustments, that are included and pro-rated by amount (#1563)" This reverts commit 5fceb46. * [MODINVOICE-554-revert]. Fix failed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Approach
Related issues