MODDCB-90 Accept existing circulation request ID

folio-org · Mar 18, 2024 · 4663816 · 4663816
1 parent 0f45a09
commit 4663816
Showing 1 changed file with 18 additions and 13 deletions.
diff --git a/src/main/java/org/folio/dcb/service/impl/EcsRequestTransactionsServiceImpl.java b/src/main/java/org/folio/dcb/service/impl/EcsRequestTransactionsServiceImpl.java
@@ -36,19 +36,7 @@ public TransactionStatusResponse createEcsRequestTransactions(String ecsRequestT
     if (circulationRequest != null && RequestStatus.isRequestOpen(
       RequestStatus.from(circulationRequest.getStatus()))) {
       if (dcbTransaction.getRole() == LENDER) {
-        dcbTransaction.setItem(DcbItem.builder()
-          .id(String.valueOf(circulationRequest.getItemId()))
-            .barcode(circulationRequest.getItem().getBarcode())
-          .build());
-        dcbTransaction.setPatron(DcbPatron.builder()
-          .id(String.valueOf(circulationRequest.getRequesterId()))
-          .barcode(circulationRequest.getRequester().getBarcode())
-          .build());
-        dcbTransaction.setPickup(DcbPickup.builder()
-          .servicePointId(String.valueOf(circulationRequest.getPickupServicePointId()))
-          .build());
-        baseLibraryService.saveDcbTransaction(ecsRequestTransactionsId, dcbTransaction,
-          dcbTransaction.getRequestId());
+        createLenderEcsRequestTransactions(ecsRequestTransactionsId, dcbTransaction, circulationRequest);
       } else {
         throw new IllegalArgumentException("Unimplemented role: " + dcbTransaction.getRole());
       }
@@ -69,4 +57,21 @@ private void checkEcsRequestTransactionExistsAndThrow(String dcbTransactionId) {
           dcbTransactionId));
     }
   }
+
+  private void createLenderEcsRequestTransactions(String ecsRequestTransactionsId,
+    DcbTransaction dcbTransaction, CirculationRequest circulationRequest) {
+    dcbTransaction.setItem(DcbItem.builder()
+      .id(String.valueOf(circulationRequest.getItemId()))
+      .barcode(circulationRequest.getItem().getBarcode())
+      .build());
+    dcbTransaction.setPatron(DcbPatron.builder()
+      .id(String.valueOf(circulationRequest.getRequesterId()))
+      .barcode(circulationRequest.getRequester().getBarcode())
+      .build());
+    dcbTransaction.setPickup(DcbPickup.builder()
+      .servicePointId(String.valueOf(circulationRequest.getPickupServicePointId()))
+      .build());
+    baseLibraryService.saveDcbTransaction(ecsRequestTransactionsId, dcbTransaction,
+      dcbTransaction.getRequestId());
+  }
 }