MODINV-1069 Fix DataImportConsumerVerticleTest in mod-inventory and Fix NPE in HoldingsItemMatcher #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldingsItemMatcher
…ldingsItemMatcher
JavokhirAbdullayev
requested review from
Aliaksandr-Fedasiuk,
dmytrokrutii,
VRohach,
KaterynaSenchenko,
RuslanLavrov and
RomanChernetskyi
KaterynaSenchenko
approved these changes
Aug 29, 2024
| @@ -73,6 +72,12 @@ protected String addCqlSubMatchCondition(DataImportEventPayload eventPayload) { | |||
| return cqlSubMatch; | |||
| } | |||
|
|
|||
| private static boolean checkIfValueIsNullOrEmpty(String value) { | |||
There was a problem hiding this comment.
@JavokhirAbdullayev , could you use another name for this method like "isNullOrEmpty"?
RomanChernetskyi
approved these changes
Aug 30, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fix NPE in HoldingsItemMatcher MODINV-1069