Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODINVOICE-17 Define API #3

Merged
merged 18 commits into from
Mar 20, 2019
Merged

MODINVOICE-17 Define API #3

merged 18 commits into from
Mar 20, 2019

Conversation

javalkar-varun
Copy link
Contributor

@javalkar-varun javalkar-varun commented Mar 15, 2019 •
edited
Loading

Purpose

https://issues.folio.org/browse/MODINVOICE-17

Approach

  • Update invoice.raml with all APIs
  • Update ModuleDescriptor with appropriate permissions
  • Generate all interfaces for Invoices implementation
  • Update .gitmodules to create ramls/acq-models sub-folder
  • Update unit tests to comply with the new interface

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@javalkar-varun javalkar-varun requested a review from a team March 15, 2019 18:48
@javalkar-varun javalkar-varun self-assigned this Mar 15, 2019
pautau-s
pautau-s reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@pautau-s pautau-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is worth to update Jenkinsfile to enable publishModDescriptor, publishAPI, mvnDeploy, runLintRamlCop.

@id-jenkins
Copy link 

INFO: lint-raml-cop: Investigating and determining configuration: mod-invoice/ramls
INFO: lint-raml-cop: Assessing schema files (https://dev.folio.org/guides/describe-schema/):
INFO: lint-raml-cop: Found 84 JSON schema files under directory './ramls'
INFO: lint-raml-cop: invoice.json: Each property "description" is present.
ERROR: lint-raml-cop: invoiceCollection.json: Missing "description" for: invoices
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/adjustment.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice_line_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice_line.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/ledger_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/budget.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fiscal_year_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/transaction.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/budget_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund_distribution_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund_distribution.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/transaction_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fiscal_year.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/encumbrance.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/ledger.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/encumbrance_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/category.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor_type.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/account_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/url_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/alias.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor_type_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/email.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/interface_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/phone_number_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/email_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/agreement.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/alias_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/changelog.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/interface.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/contact_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/agreement_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/address.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/category_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/account.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/url.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/address_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/error.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/contact.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/phone_number.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/receivingCollection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/receivingResults.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/composite_purchase_orders.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/composite_po_line.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/po_number.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/composite_purchase_order.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/checkinCollection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/common/schemas/sequence_number.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/po_line_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/receiving_history.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/adjustment.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/po_line.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/receiving_history_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/contributor.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/alert.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/vendor_detail.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/physical.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/renewal.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/cost.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/location.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/purchase_order.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/fund_distribution.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/details.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/close_reason.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/license.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/alert_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/reporting_code_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/piece.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/reporting_code.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/purchase_order_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/claim.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/piece_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/eresource.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/source.json: Each property "description" is present.
INFO: lint-raml-cop: Not assessing RAML/Schema or examples against schema, as per option '--json-only'.
ERROR: lint-raml-cop: There were processing errors. See list above.

@id-jenkins
Copy link 

INFO: lint-raml-cop: Investigating and determining configuration: mod-invoice/ramls
INFO: lint-raml-cop: Assessing schema files (https://dev.folio.org/guides/describe-schema/):
INFO: lint-raml-cop: Found 84 JSON schema files under directory './ramls'
ERROR: lint-raml-cop: invoiceCollection.json: Missing "description" for: invoices
INFO: lint-raml-cop: invoice.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/reporting_code.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/close_reason.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/eresource.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/adjustment.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/source.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/physical.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/piece.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/po_line_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/contributor.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/alert.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/purchase_order.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/alert_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/renewal.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/receiving_history.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/details.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/purchase_order_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/claim.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/fund_distribution.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/po_line.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/cost.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/receiving_history_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/piece_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/vendor_detail.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/reporting_code_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/location.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders-storage/schemas/license.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/encumbrance_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/transaction.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/ledger_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/budget_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund_distribution_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/transaction_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/budget.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/ledger.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fund_distribution.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fiscal_year_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/fiscal_year.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-finance/schemas/encumbrance.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/checkinCollection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/composite_purchase_order.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/composite_purchase_orders.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/receivingResults.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/receivingCollection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/composite_po_line.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-orders/schemas/po_number.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/phone_number.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/url.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor_type.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/agreement.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/address_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/account_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor_type_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/contact_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/category_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/interface_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/category.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/phone_number_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/alias.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/interface.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/email_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/address.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/contact.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/error.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/url_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/changelog.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/alias_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/vendor.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/email.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/account.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-vendors/schemas/agreement_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/common/schemas/sequence_number.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/adjustment.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice_line_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice_collection.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice.json: Each property "description" is present.
INFO: lint-raml-cop: acq-models/mod-invoice-storage/schemas/invoice_line.json: Each property "description" is present.
INFO: lint-raml-cop: Not assessing RAML/Schema or examples against schema, as per option '--json-only'.
ERROR: lint-raml-cop: There were processing errors. See list above.

@craigmcnally
Copy link
Contributor

Whoops, looks like there are some raml-cop issues you need to resolve

@javalkar-varun
Copy link
Contributor Author

@craigmcnally Done, I had an extra copy of schema locally which was throwing an error. Removing those fixed raml-lint-cop error.

KVupp
KVupp reviewed Mar 18, 2019
View reviewed changes
descriptors/ModuleDescriptor-template.json Outdated
},
{
"methods": ["POST"],
"pathPattern": "/invoice",
"permissionsRequired": ["invoice.item.post"]
"pathPattern": "/invoicing/invoices",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev.folio.org/guidelines/naming-conventions/ . According to the naming conventions

The first portion is the exact name of the responsible module (back-end modules drop the mod- prefix).

Should we be renaming the module? or the permissions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't rename the module then permission names will be like:
invoice.invoice.item.post
invoice.invoice-lines.item.post ?

Copy link
Contributor Author

@javalkar-varun javalkar-varun Mar 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer this and keep the module name as is:
invoice.item.post
invoice-lines.item.post
invoice-number.item.post
Any thoughts @craigmcnally @piotr-kalashuk ?

Copy link
Contributor

@craigmcnally craigmcnally Mar 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn it, I was unaware of the "exact name of the responsible module" part.

I guess it should be:
invoice.invoices.item.post
invoice.invoice-lines.item.post
etc.

Sorry for the confusion @javalkar-varun I should have known about this convention. Good catch @KVupp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. I have corrected permission names.

KVupp
KVupp reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@KVupp KVupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of this PR, but the deployment descriptor has the parameter embed_postgres=true. Can you please remove that as this is a business logic module.

craigmcnally
craigmcnally approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@craigmcnally craigmcnally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Varun. I've updated the API listing document to reflect the new paths

KVupp
KVupp reviewed Mar 19, 2019
View reviewed changes
ramls/invoice.raml
exampleCollection: !include acq-models/mod-invoice-storage/examples/invoice_line_collection.sample
exampleItem: !include acq-models/mod-invoice-storage/examples/invoice_line.sample
is: [validate]
get:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add pageable to get end point

KVupp
KVupp approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@KVupp KVupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one inline comment. It looks good otherwise!

@javalkar-varun javalkar-varun merged commit ab647e6 into master Mar 20, 2019
@piotr-kalashuk piotr-kalashuk deleted the MODINVOICE-17 branch April 29, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pautau-s pautau-s pautau-s left review comments

@KVupp KVupp KVupp approved these changes

@craigmcnally craigmcnally craigmcnally approved these changes

Assignees

@javalkar-varun javalkar-varun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@javalkar-varun @id-jenkins @craigmcnally @KVupp @pautau-s