Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions fixes #183

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Permissions fixes #183

merged 6 commits into from
Oct 1, 2024

Conversation

EthanFreestone
Copy link
Contributor

  • Added github actions file to enable validation of the module descriptor (ahead of trying to crank out the permission fixes
  • Permission tweaks to satisfy Eureka

Added github actions file to enable validation of the module descriptor (ahead of trying to crank out the permission fixes
@EthanFreestone EthanFreestone marked this pull request as draft September 24, 2024 14:19

This comment was marked as outdated.

Copy link

"Permission protects more than one endpoint",
"oa.refdata.collection.get [/oa/refdata/{domain}/{property} [GET], /oa/refdata [GET]]"

"Permission protects more than one endpoint",
"oa.publicationRequest.item.post [/oa/publicationRequest [POST], /oa/publicationRequest/{id} [PUT]]"

Proposed granular permissions changes to bring module up to scratch with Eureka's needs
@EthanFreestone
Copy link
Contributor Author

EthanFreestone commented Sep 25, 2024

Double check refdata perms acutally line up with expectations -- as we will likely need similar in all apps

See mod-licenses PR:
folio-org/mod-licenses#271

@EthanFreestone EthanFreestone marked this pull request as ready for review October 1, 2024 14:50
@EthanFreestone EthanFreestone merged commit 9b1cc09 into master Oct 1, 2024
5 checks passed
@EthanFreestone EthanFreestone deleted the ci/validate_module branch October 1, 2024 14:50
Jack-Golding pushed a commit that referenced this pull request Nov 6, 2024
* ci: Validate module

Added github actions file to enable validation of the module descriptor (ahead of trying to crank out the permission fixes

* ci: Update github action to latest versions

* build: Permissions changes

Proposed granular permissions changes to bring module up to scratch with Eureka's needs

* ci: Docker compose not docker-compose

* chore: Tweak to bring refdata in line with agreements branch

* style: Fix JSON styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant