Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reindex) Implement endpoint to run merge reindex stage only for failed ranges #721

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat(reindex) Implement endpoint to run merge reindex stage only for failed ranges #721

wants to merge 10 commits into from

Conversation

viacheslavkol
Copy link
Contributor

@viacheslavkol viacheslavkol commented Dec 24, 2024 •
edited
Loading

Purpose

Implement endpoint to run merge reindex stage only for failed ranges

Approach

Implement repository methods
Implement API endpoint
Bump indices interface version

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

MSEARCH-906

@viacheslavkol
feat(reindex): Extend range tables with the status column
3084cad 
- add status, failCause columns to merge/upload range tables
- implement status population logic

Closes: MSEARCH-870
@viacheslavkol
Remove redundant mock
c20af70
@viacheslavkol
feat(reindex): Implement endpoint to run merge reindex stage only for…
5e03fef 
… failed ranges

Implements: MSEARCH-906
@viacheslavkol viacheslavkol self-assigned this Dec 24, 2024
@viacheslavkol viacheslavkol marked this pull request as ready for review December 24, 2024 11:26
@viacheslavkol viacheslavkol requested a review from a team as a code owner December 24, 2024 11:26
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin Awaiting requested review from psmagin psmagin is a code owner automatically assigned from folio-org/spitfire-backend

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf

At least 2 approving reviews are required to merge this pull request.

Assignees

@viacheslavkol viacheslavkol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viacheslavkol @mukhiddin-yusuf