STCOM-1345 <Selection>
- Call onFilter
in side-effect for asyncFilter
#2358
+204
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STCOM-1345
Shoring up this component feature on this side of the refactor. The boolean prop
asyncFilter
will let the component know that option filtering will happen via request/not within the component. So it will just render thedataOptions
prop as it is provided. Emptying the list and setting aloading
prop are the responsibilities of the application.