Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STCOM-1353 Export StripesOverlayWrapper and document its existence, and usage #2360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

STCOM-1353 Export StripesOverlayWrapper and document its existence, and usage #2360

wants to merge 1 commit into from
+43 −11

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Oct 3, 2024

STCOM-1353

UI modules can import StripesOverlayWrapper to wrap component trees where usage of the usePortal prop will be prevalent among children.

    <StripesOverlayWrapper>
       <ListOfOverlayComponentsLikeDatepickerSelectionEtc />
    </StripesOverlayWrapper>

Additonal: Included documentation and links to said documentation about portals within component readmes.

@JohnC-80 JohnC-80 requested review from a team and zburke October 3, 2024 22:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Bigtest Unit Test Results

    1 files  ±0      1 suites  ±0   14s ⏱️ ±0s
1 521 tests ±0  1 513 ✅ ±0  8 💤 ±0  0 ❌ ±0 
1 523 runs  ±0  1 515 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit c4250f2. ± Comparison against base commit 20c4778.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke Awaiting requested review from zburke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohnC-80