Use eslint-config-stripes #42
Conversation
| } | ||
| return false; |
There was a problem hiding this comment.
Is this a linting rule that got triggered?
There was a problem hiding this comment.
Yes https://eslint.org/docs/rules/no-else-return
I have mixed feelings about that rule.
There was a problem hiding this comment.
Yeah, these days I favor symmetry over efficiency when given a choice
There was a problem hiding this comment.
As a general policy, we want ESLint to be our servant, not our master. Bondage-and-discipline rules like no-nested-ternary and no-plusplus can go, with no period of mourning required. no-else-return definitely belongs in this category!
There was a problem hiding this comment.
|
Re: Jenkins build failures: is it running into a cached npm registry or something? |
|
Right. npmjs.org is cached. The builds passes now. |
Switches to using shared FOLIO eslint config: https://github.com/folio-org/eslint-config-stripes