STSMACOM-546 lock to axe-core 4.3.3 to avoid test failures #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master-branch builds are now failing in CI/CD, although they run successfully locally. Maybe it was the `axe-core` update?
|
Kudos, SonarCloud Quality Gate passed!
|
zburke
changed the title
|
@zburke Axe-core 4.3.5 was released, in which we've disabled the test for using non-global ARIA attributes on elements with no role. This will be reintroduced in 4.4.0, just to give a heads up for that. But it wasn't meant to go into a patch. |
|
Thanks for the heads-up, @WilcoFiers. It was extra work of no benefit to you to comment here and explain the situation, but I really appreciate that you took the time to do it. Class act! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axe-core4.3.4causes test failures here on the master branch that4.3.3does not.From dequelabs/axe-core#3241:
We should look at this again in a few weeks and hope to revert this PR. Locking directly onto a patch version is not great.
Refs STSMACOM-546