Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIAC-50 Update outdated dependencies #148

Merged
merged 1 commit into from
Sep 1, 2022
Merged

UIAC-50 Update outdated dependencies #148

merged 1 commit into from
Sep 1, 2022

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Aug 30, 2022

Purpose

https://issues.folio.org/browse/UIAC-50

Approach

NB: @testing-library/react can't be upgraded to latest version, because from version 13 react <=17 is not supported (https://github.com/testing-library/react-testing-library/releases/tag/v13.0.0)

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Aug 30, 2022
@github-actions
Copy link

Jest Unit Test Statistics

52 tests  ±0   52 ✔️ ±0   49s ⏱️ +9s
11 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit c3c2ae6. ± Comparison against base commit ee3d902.

@github-actions
Copy link

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit c3c2ae6. ± Comparison against base commit ee3d902.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@usavkov-epam usavkov-epam requested review from a team and zburke August 30, 2022 12:56
@usavkov-epam usavkov-epam merged commit e26cb39 into master Sep 1, 2022
@usavkov-epam usavkov-epam deleted the UIAC-50 branch September 1, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants