Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERM-3390 Show columns: Name column should not be in the list of unsel… #1366

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

CalamityC
Copy link
Contributor

…ectable columns

  • exclude 'name' column from toggle menu

…ectable columns

* exclude 'name' column from toggle menu
Copy link

github-actions bot commented Nov 4, 2024

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

Copy link

github-actions bot commented Nov 4, 2024

Jest Unit Test Results

    1 files  ±0    156 suites  ±0   4m 5s ⏱️ -3s
1 048 tests +3  1 048 ✅ +3  0 💤 ±0  0 ❌ ±0 
1 055 runs  +3  1 055 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit ebbe93a. ± Comparison against base commit 1dd4346.

This pull request removes 9 and adds 12 tests. Note that renamed tests count towards both.
AgreementLinesRoute rendering the route with permissions re-rendering the route renders the agreementLines component ‑ AgreementLinesRoute rendering the route with permissions re-rendering the route renders the agreementLines component
AgreementsRoute rendering the route with permissions re-rendering the route renders the agreements component ‑ AgreementsRoute rendering the route with permissions re-rendering the route renders the agreements component
CoveredEResourcesList choosing the dropdown options ‑ CoveredEResourcesList choosing the dropdown options
CoveredEResourcesList clicking the filter buttons should call the onFilterEResources callback ‑ CoveredEResourcesList clicking the filter buttons should call the onFilterEResources callback
CoveredEResourcesList renders the expected filter buttons ‑ CoveredEResourcesList renders the expected filter buttons
EResourceViewRoute rendering the EResourceViewRoute re-rendering the route renders the EResource component ‑ EResourceViewRoute rendering the EResourceViewRoute re-rendering the route renders the EResource component
PackagesRoute rendering the route with permissions re-rendering the route renders the packages component ‑ PackagesRoute rendering the route with permissions re-rendering the route renders the packages component
PlatformsRoute rendering the route with permissions re-rendering the route renders the platforms component ‑ PlatformsRoute rendering the route with permissions re-rendering the route renders the platforms component
TitlesRoute rendering the route with permissions re-rendering the route renders the titles component ‑ TitlesRoute rendering the route with permissions re-rendering the route renders the titles component
AgreementsRoute rendering the route with permissions did not redirect to view pane ‑ AgreementsRoute rendering the route with permissions did not redirect to view pane
AgreementsRoute rendering the route with single agreement redirected to view pane ‑ AgreementsRoute rendering the route with single agreement redirected to view pane
CoveredEResourcesList All filter button clicking the All button onFilterEResources callback called ‑ CoveredEResourcesList All filter button clicking the All button onFilterEResources callback called
CoveredEResourcesList All filter button renders the All button ‑ CoveredEResourcesList All filter button renders the All button
CoveredEResourcesList Current filter button clicking the Current button onFilterEResources callback called ‑ CoveredEResourcesList Current filter button clicking the Current button onFilterEResources callback called
CoveredEResourcesList Current filter button renders the Current button ‑ CoveredEResourcesList Current filter button renders the Current button
CoveredEResourcesList Dropped filter button clicking the Dropped button onFilterEResources callback called ‑ CoveredEResourcesList Dropped filter button clicking the Dropped button onFilterEResources callback called
CoveredEResourcesList Dropped filter button renders the Dropped button ‑ CoveredEResourcesList Dropped filter button renders the Dropped button
CoveredEResourcesList Future filter button clicking the Future button onFilterEResources callback called ‑ CoveredEResourcesList Future filter button clicking the Future button onFilterEResources callback called
CoveredEResourcesList Future filter button renders the Future button ‑ CoveredEResourcesList Future filter button renders the Future button
…

♻️ This comment has been updated with latest results.

…ectable columns

* exclude 'name' column from toggle menu
@CalamityC CalamityC marked this pull request as ready for review November 4, 2024 14:36
Copy link
Contributor

@EthanFreestone EthanFreestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing because ColumnManager is now mocked by default. Easiest fix would be to use jest.requireActual for this test, but I leave that up to you @CalamityC

Copy link

@EthanFreestone EthanFreestone merged commit e91e1b1 into master Nov 11, 2024
18 checks passed
@EthanFreestone EthanFreestone deleted the erm-3390 branch November 11, 2024 16:04
Jack-Golding pushed a commit that referenced this pull request Nov 29, 2024
#1366)

* ERM-3390 Show columns: Name column should not be in the list of unselectable columns

* exclude 'name' column from toggle menu

* ERM-3390 Show columns: Name column should not be in the list of unselectable columns

* exclude 'name' column from toggle menu

* fix test

* fix more tests

* test: Minor test tweaks (not really relevant)

* test: Added route testing useEffect redirect (WIP... can be improved)

* test: Commented out now useless tests

* test: Fixed manual mock usage

* test: Add mock for useEresourcesEnabled

---------

Co-authored-by: EthanFreestone <54310740+EthanFreestone@users.noreply.github.com>
Co-authored-by: Ethan Freestone <ethan.freestone@k-int.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants