-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ERM-3390 Show columns: Name column should not be in the list of unsel… #1366
Conversation
…ectable columns * exclude 'name' column from toggle menu
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
Jest Unit Test Results 1 files ±0 156 suites ±0 4m 5s ⏱️ -3s Results for commit ebbe93a. ± Comparison against base commit 1dd4346. This pull request removes 9 and adds 12 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
…ectable columns * exclude 'name' column from toggle menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failing because ColumnManager is now mocked by default. Easiest fix would be to use jest.requireActual
for this test, but I leave that up to you @CalamityC
Quality Gate passedIssues Measures |
#1366) * ERM-3390 Show columns: Name column should not be in the list of unselectable columns * exclude 'name' column from toggle menu * ERM-3390 Show columns: Name column should not be in the list of unselectable columns * exclude 'name' column from toggle menu * fix test * fix more tests * test: Minor test tweaks (not really relevant) * test: Added route testing useEffect redirect (WIP... can be improved) * test: Commented out now useless tests * test: Fixed manual mock usage * test: Add mock for useEresourcesEnabled --------- Co-authored-by: EthanFreestone <54310740+EthanFreestone@users.noreply.github.com> Co-authored-by: Ethan Freestone <ethan.freestone@k-int.co.uk>
…ectable columns