Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERM-3298, Block save on invalid date in license edit #749

Merged
merged 4 commits into from
Sep 24, 2024
Merged

ERM-3298, Block save on invalid date in license edit #749

merged 4 commits into from
Sep 24, 2024

Conversation

MonireRasouli
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Jest Unit Test Results

237 tests  ±0   237 ✅ ±0   1m 23s ⏱️ -45s
 44 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit b7d50d3. ± Comparison against base commit bbe7384.

♻️ This comment has been updated with latest results.

@EthanFreestone EthanFreestone marked this pull request as ready for review September 23, 2024 12:13
EthanFreestone
EthanFreestone requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@EthanFreestone EthanFreestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to do the important step of importing the AppValidateDatepicker from stripes-components, which is necessary for this fix to actually work as specified

@MonireRasouli MonireRasouli changed the title Erm 3298 ERM-3298, Block save on invalid date in license edit Sep 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@EthanFreestone EthanFreestone merged commit 9d9e85e into master Sep 24, 2024
14 of 15 checks passed
@EthanFreestone EthanFreestone deleted the ERM-3298 branch September 24, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanFreestone EthanFreestone EthanFreestone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonireRasouli @EthanFreestone