Granted oa.settings.read on module.oa.enabled #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
|
Jack-Golding
approved these changes
Aug 21, 2024
Jack-Golding
pushed a commit
that referenced
this pull request
Sep 12, 2024
(cherry picked from commit 3015eae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module settings are needed by all users of the OA module so that they can be used in the module. In particular the
default_taxappSetting is needed when creating chargesBy granting
oa.settings.readas a subpermission ofmodule.oa.enabledit ensures that any user of the module can read the settings.