Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase performance and fix memory leak #729

Closed
wants to merge 4 commits into from

Conversation

CorvusCorrax
Copy link

See #728

@CorvusCorrax CorvusCorrax changed the title Remove referencePDF writable stream Increase performance and fix memory leak Sep 13, 2017
@rogierslag
Copy link

Any action on this? The memory leak really hurts us (we now simply restart all services dependent on pdfkit based on their memory usages)

@jaysonduenas
Copy link

jaysonduenas commented May 16, 2018

This is awesome. I tested this in my local machine. Below is the comparison.

Context
1,000 Pages
Table with 11+ columns
This is a huge pdf with a lot of data inside

Current Version
Elapsed Time: 4.02mins
Memory Consumption: 4.8gb

This Pull Request
Elapsed Time: 2.53mins
Memory Consumption: 2.8gb

I hope we can merge this to master soon.

@jean507
Copy link

jean507 commented Jun 19, 2018

Can someone merge this please!

@LJNeon
Copy link

LJNeon commented Jul 20, 2018

@devongovett @alafr please merge this

@jBox
Copy link

jBox commented Jul 25, 2018

@devongovett @alafr please merge this! This is awesome.

blikblum added a commit to blikblum/pdfkit that referenced this pull request Aug 18, 2018
@blikblum blikblum mentioned this pull request Aug 19, 2018
5 tasks
@rusjoan
Copy link

rusjoan commented Aug 27, 2018

Obviously, repo is unmaintained. Time to choose the new owner

@nrkn
Copy link

nrkn commented Aug 27, 2018

@rusjoan there is currently significant work underway to add tests and convert to ES6 in order to get the project moving forward again:

#859

@blikblum
Copy link
Member

Already incorporated in recent release

@blikblum blikblum closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants