-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raysu 2023 0519 #162
base: master
Are you sure you want to change the base?
Raysu 2023 0519 #162
Conversation
The most important changes are the ipfs for the LS625 and IPS120 power supplies! |
|
||
// Let gates settle | ||
sc_sleep(S.delayy*20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is probably better to keep delayy instead of hard coding a 2 second sleep. It would be better to add an optional parameter to Scank2400 that allows you to set delayy and if not set will use default of 2.
rampK2400Voltage(S.instrIDx, setpointx, ramprate=S.rampratex) | ||
else | ||
setK2400Voltage(S.instrIDx, setpointx) | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not essential, but nice to keep orderly indenting.
Required/Scans.ipf
Outdated
fast=0 | ||
endif | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In IGOR if the parameter is default it is already set to 0. But it is good to be explicit.
A nice 1 liner would be:
fast = paramisdefault(fast) ? 1 : fast
sc_sleep(S.delayx) | ||
if(fast==1) | ||
setlS625field(S.instrIDx, setpointx) | ||
sc_sleep(max(S.delayx, (S.delayx+60*abs(finx-startx)/numptsx/ramprate))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this math do? Looks like you have the time in minutes for a ramp to complete divided by the number of points in x. So if you take 1 data point this is the same as setlS625fieldwait(S.instrIDx, setpointx) but if you take 1e6 data points then you will start collecting data immediately??
@@ -247,6 +247,18 @@ function AutoSRSPhase(instrID) // Units: deg | |||
writeInstr(instrID, "APHS \n") | |||
end | |||
|
|||
function AutoSRSSens(instrID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write a comment on what this function does.
@@ -324,6 +324,99 @@ function Scan_n(instrIDx,instrIDy,fixedD,startn,finn,numptsn,delayn,rampraten, [ | |||
end | |||
|
|||
|
|||
|
|||
function Scan_n_limit(instrIDx,instrIDy,fixedD,startn,finn,numptsn,delayn,rampraten, limitx, limity, [y_label, comments, nosave]) //Units: mV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this function do? Write a comment.
Everything looks fine to me. Most of the changes were in Scan_n_D_Bxyz.ipf which I never use. |
…he gate capacitance New updates to the scan_n_d codes incorporating a division ratio in the gate capacitance
Open connections to the lakeshore magnet power supply parameters corrected. Tested to work in the LD system
Errors associated with connecting to the IPS power supply were also corrected.