Issue #239 launcher attachments #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also corrected spelling errors in original comments.
shadow-fa
requested changes
Jun 21, 2019
done by shadow-fa Co-Authored-By: shadow-fa <shadow-fa@users.noreply.github.com>
shadow-fa
previously approved these changes
Jun 21, 2019
|
Looks good to me, but maybe @SamLex should take a look as well |
Radio bags will be added with Contact gear - declaring this variable doesn't do anything until then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes issue #239 by adding sections to faction assignGear files to define launcher attachments, as well as adding the appropriate variables to fn_assignGear, and adding a handler section to assignGear_attachments. This is mostly a copy of the ordinary attachment handling, just uses addSecondaryWeaponItem instead.