Add virtual faction aliases to other components #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assignGear accepts some faction aliases for use with Virtual Faction such as "aaf" for "ind_f". This PR adds those aliases to other components to better accommodate new VF-only factions.
Per host discussion, NPR will be an OPFOR faction. This updates their classification in groupMarkers to match.
shadow-fa
reviewed
Jul 31, 2019
Also takes care of a couple of formatting typos.
shadow-fa
reviewed
Jul 31, 2019
shadow-fa
previously approved these changes
Jul 31, 2019
SamLex
requested changes
Aug 3, 2019
SamLex
requested changes
Aug 4, 2019
SamLex
approved these changes
Aug 4, 2019
SamLex
added
S5:Tested; Awaiting Release
and removed
S4:Merged; Awaiting Testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assignGear accepts some faction aliases for use with Virtual Faction such as "aaf" for "ind_f". This PR adds those aliases to other components to better accommodate new VF-only factions, specifically NPR.
Also updates groupMarkers to reflect than NPR will be OPFOR in the template.
Components affected: groupData, assignInsignia, briefing