Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

368 turn off direct chat for spectators #369

Merged
merged 1 commit into from
Dec 7, 2022
Merged

368 turn off direct chat for spectators #369

merged 1 commit into from
Dec 7, 2022

Conversation

NikkoJT
Copy link
Collaborator

@NikkoJT NikkoJT commented May 16, 2022

See #368

@NikkoJT NikkoJT requested review from costno, SamLex and shadow-fa May 16, 2022 03:35
Copy link
Member

@SamLex SamLex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

As an aside, I don't think this will work for slotted Spectators since I don't believe fn_activateSpectator is run for them. But this probably isn't an issue as these slots are rarely used.

@NikkoJT
Copy link
Collaborator Author

NikkoJT commented Nov 12, 2022

This fix currently persists into "real life" if the spectator reslots. I (or you) need to find a way to get around that before this can go ahead.

@SamLex
Copy link
Member

SamLex commented Nov 13, 2022

I think the neatest, least impact way of doing this would be adding the postInit attribute to the terminateSpectator function. I think that'll execute it when a player JIPs.

It should be fine to run this in normal start and JIP scenarios; making sure directChat is enabled is whatever and terminating the spectator should be a no-op if it's not running. But this covers the JIP'ing spectator case as it re-enables directChat and makes sure the spectator is terminated (which we haven't seen issues with but you never know)

@NikkoJT
Copy link
Collaborator Author

NikkoJT commented Nov 13, 2022

That seems like a good avenue to explore but we need to make sure it accounts for people using the actual spectator slots.

@NikkoJT
Copy link
Collaborator Author

NikkoJT commented Dec 3, 2022

A fix for this was added in #360 - the radio system now turns on direct chat for non-spectator units as part of its initialisation

@NikkoJT NikkoJT merged commit a56ec34 into dev Dec 7, 2022
@NikkoJT NikkoJT deleted the 368-ghost-voices branch April 1, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants