Skip to content

Commit

Permalink
fix(form): action input had wrong border radius in some cases
Browse files Browse the repository at this point in the history
.ui.input in .ui.form has border-radius at all corners.

Fomantic-UI/src/definitions/collections/form.less
Line 411 in 2f3312f
 border-radius: @inputFocusBorderRadius; 

Unfortunately, this override brings border-radius to .ui.action.input.
This PR removes border-radius from .ui.action.input in .ui.form where radius not needed.

Closes #1184, #1185
  • Loading branch information
TATSUNO Yasuhiro authored and Sean committed Dec 22, 2019
1 parent 6e7104c commit 8cb8d8a
Showing 1 changed file with 33 additions and 0 deletions.
33 changes: 33 additions & 0 deletions src/definitions/collections/form.less
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,39 @@
background: @inputFocusBackground;
box-shadow: @inputFocusBoxShadow;
}
& when (@variationInputAction) {
.ui.form .ui.action.input:not(.left) input:not([type]):focus,
.ui.form .ui.action.input:not(.left) input[type="date"]:focus,
.ui.form .ui.action.input:not(.left) input[type="datetime-local"]:focus,
.ui.form .ui.action.input:not(.left) input[type="email"]:focus,
.ui.form .ui.action.input:not(.left) input[type="number"]:focus,
.ui.form .ui.action.input:not(.left) input[type="password"]:focus,
.ui.form .ui.action.input:not(.left) input[type="search"]:focus,
.ui.form .ui.action.input:not(.left) input[type="tel"]:focus,
.ui.form .ui.action.input:not(.left) input[type="time"]:focus,
.ui.form .ui.action.input:not(.left) input[type="text"]:focus,
.ui.form .ui.action.input:not(.left) input[type="file"]:focus,
.ui.form .ui.action.input:not(.left) input[type="url"]:focus {
border-top-right-radius: 0;
border-bottom-right-radius: 0;
}

.ui.form .ui.action.input.left input:not([type]),
.ui.form .ui.action.input.left input[type="date"],
.ui.form .ui.action.input.left input[type="datetime-local"],
.ui.form .ui.action.input.left input[type="email"],
.ui.form .ui.action.input.left input[type="number"],
.ui.form .ui.action.input.left input[type="password"],
.ui.form .ui.action.input.left input[type="search"],
.ui.form .ui.action.input.left input[type="tel"],
.ui.form .ui.action.input.left input[type="time"],
.ui.form .ui.action.input.left input[type="text"],
.ui.form .ui.action.input.left input[type="file"],
.ui.form .ui.action.input.left input[type="url"] {
border-bottom-left-radius: 0;
border-top-left-radius: 0;
}
}
.ui.form textarea:focus {
color: @textAreaFocusColor;
border-color: @textAreaFocusBorderColor;
Expand Down

0 comments on commit 8cb8d8a

Please sign in to comment.