Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calendar] Chrome chose the wrong hour in 24-hour format on some cases #1354

Closed
kawaji opened this issue Mar 6, 2020 · 3 comments
Closed

[Calendar] Chrome chose the wrong hour in 24-hour format on some cases #1354

kawaji opened this issue Mar 6, 2020 · 3 comments
Assignees
@exoego
Labels
browser/chromium Any issues relating to Chromium (Chrome, Edge (new), Opera, Brave etc.) type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.8.7

Comments

@kawaji
Copy link

kawaji commented Mar 6, 2020

Chrome: 80.0.3987.132

https://fomantic-ui.com/modules/calendar.html#24-hour-format

If you enter a time for this sample, the time selected in the popup is incorrect.

1 -> 0:00
1: -> 1:00
13 -> 13:00

Entering 2 digits works correctly.

This problem does not occur with FireFox.

fomantic
@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug browser/chromium Any issues relating to Chromium (Chrome, Edge (new), Opera, Brave etc.) labels Mar 6, 2020
@exoego exoego changed the title [Chrome]Not recognized as 1 o'clock in 24-hour format [Calendar] Chrome chose the wrong hour in 24-hour format on some case Mar 6, 2020
@exoego exoego changed the title [Calendar] Chrome chose the wrong hour in 24-hour format on some case [Calendar] Chrome chose the wrong hour in 24-hour format on some cases Mar 6, 2020
@exoego
Copy link
Contributor

exoego commented Mar 6, 2020 •
edited
Loading

This is reproducible.

  • When 0 .. 12 entered, 0:00 hour is chosen.
  • When 13 .. 23 entered, the matching hour is chosen as same as in other browsers.
  • With : like 0: or 1:, the matching hour is chosen as same as in other browsers.

chrome-hours2

@exoego
Copy link
Contributor

exoego commented Mar 6, 2020

I will look into this issue and open a PR.

@exoego exoego self-assigned this Mar 6, 2020
@exoego exoego mentioned this issue Jul 12, 2020
Merged
@exoego exoego added the state/has-pr An issue which has a related PR open label Jul 12, 2020
@lubber-de
Copy link
Member

Fixed by #1569

@lubber-de lubber-de added this to the 2.8.7 milestone Jul 12, 2020
@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Jul 12, 2020
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exoego exoego

Labels
browser/chromium Any issues relating to Chromium (Chrome, Edge (new), Opera, Brave etc.) type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.8.7
Development

No branches or pull requests
3 participants
@exoego @kawaji @lubber-de