[Calendar] Chrome chooses wrong hour on time-only calendar #1569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fomantic-UI/src/definitions/modules/calendar.js
Lines 1355 to 1358 in 0269a82
The above code expects parsing on partial input, e.g.
1
, to be failed onnew Date("1")
.However, there are incosintency between browsers on how
new Date
consturctor orDate.parse
works.On Chrome,
new Date("1")
or such can create instance of Date.So,
getDate
is a number, then hour is not chosen correctly.This PR adds a check input is number-only `^[0-9]+$ or not.
If input is number-only, it should go to time-only or date-only logic.
Testcase
Broken (on Chrome)
https://jsfiddle.net/m8a4r3t9/
Fixed (on Chrome)
https://jsfiddle.net/9og37k1t/1/
Closes
#1354