Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Loader] Compatibility broken with Semantic-UI-React #1357

Closed
AKorezin opened this issue Mar 7, 2020 · 1 comment
Closed

[Loader] Compatibility broken with Semantic-UI-React #1357

AKorezin opened this issue Mar 7, 2020 · 1 comment
Labels
state/wont-fix Anything which isn't going to be fixed

Comments

@AKorezin
Copy link

AKorezin commented Mar 7, 2020

Description:

Pull request #359 breaks loader inside dimmer with react.

Semantic-UI-React creates additional block inside dimmer:

<Dimmer active>
  <Loader />
</Dimmer>

creates:

<div class="ui active transition visible dimmer">
  <div class="content">
    <div class="ui loader">
    </div>
  </div>
</div>

So loader styles are not applied.

Link to the source code of dimmer in Semantic-UI-React repo.

Should I create an additional issue in Sematic-UI-React?

@lubber-de
Copy link
Member

lubber-de commented Mar 7, 2020

Yes, please address this at the SUI React Repo, because also the SUI Docs for loader tell you to create the loader as direct child of the dimmer itself.
The mentioned PR corrects the inheritance for dimmer loaders and we won't revert this.
Instead SUI React should handle dimmer loaders as a separate child instead of wrapping any kind of content into a separate content div which would still be compatible to SUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/wont-fix Anything which isn't going to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants