[Loader,Modal] Default Loader color settings in Dimmers had impact on loaders in modals #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loaders in modals
lubber-de
added
type/bug
y0hami
removed
state/awaiting-reviews
Merged
This was referenced Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a modal also had loaders used, these got the wrong default color (white if dimmer of modal was black, so white color on white modal background was...uhm..white 🤣 )
I fixed this now for every combination of dimmer and modal
Also fixed unnessary css settings and missing color in inverted modal action (came across this while testing the original SUI issue)
Testcase
http://jsfiddle.net/o92qen2j/10/
In every Modal there is a inline loader in the actions section which is not visible if the fix is not applied
Remove CSS to see the original issue again
Closes
Semantic-Org/Semantic-UI#4014