Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build Process] gulp install not running #145

Closed
y0hami opened this issue Oct 2, 2018 · 6 comments
Closed

[Build Process] gulp install not running #145

y0hami opened this issue Oct 2, 2018 · 6 comments
Assignees
@y0hami
Labels
priority/high Anything which is in high priority type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process

Comments

@y0hami
Copy link
Member

y0hami commented Oct 2, 2018 •
edited
Loading

Bug Report

Started after the new release with the new gulp 4 PR.

Steps to reproduce

  1. npm install fomantic-ui
  2. select all components when prompt

Expected result

Should install correctly

Actual result

Install process crashes with following error

Did you forget to signal async completion?

Version

2.6.1
@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug priority/high Anything which is in high priority type/build Anything related to the build process labels Oct 2, 2018
@y0hami y0hami self-assigned this Oct 2, 2018
@y0hami
Copy link
Member Author

y0hami commented Oct 2, 2018

@acconrad You may want to look into this for your PR.

@y0hami y0hami mentioned this issue Oct 2, 2018
Merged
@y0hami
Copy link
Member Author

y0hami commented Oct 2, 2018

Reverted the changes for now.

@y0hami y0hami closed this as completed Oct 2, 2018
@acconrad
Copy link

acconrad commented Oct 2, 2018

Sorry I'm confused, what needs to be addressed here? This looks like an offshoot of Semantic-UI. If you run gulp on this project does that error pop up here but not on Semantic? I'm guessing there are slight nuances and differences that weren't accounted for here that work there.

@ColinFrick
Copy link
Member

@acconrad try to install your branch in an empty npm project:
$ npm init
$ npm i --save-dev gulp@4
$ npm i acconrad/Semantic-UI#acc-upgrade-gulp4

@acconrad
Copy link

acconrad commented Oct 2, 2018

Fixed @hammy2899 @ColinFrick . It wasn't actually broken, it was a false flag. The older version of Semantic UI used a process.exit which is fine in Gulp 3, but in Gulp 4 the proper way is to pass in a done() callback into a gulp.task and close that way. That was the last stone I forgot to turn, but it is now completed! My branch is now updated and if you run through it again you should get exactly what you need without errors this time :)

@ColinFrick
Copy link
Member

Thanks for the update @acconrad I will test it further later today.

@lubber-de lubber-de mentioned this issue Mar 24, 2023
Merged
lubber-de added a commit that referenced this issue Mar 31, 2023
@lubber-de
feat(dropdown): optional keeping the searchterm
7986b3f 
New option keepSearchTerm for multiple search selection dropdowns. This (almost) reflects the current SUI behavior (which we fixed already)

The list stays filtered
The search term is not removed on item selection (to make it clear why the list is still filtered on selection)
This PR also removes the completely unused glyphWidth setting. This is all done in CSS instead of JS (not even in current SUI) and we fixed the search width glyph calculation already by #145 which in turn closes Semantic-Org/Semantic-UI#6655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@y0hami y0hami

Labels
priority/high Anything which is in high priority type/bug Any issue which is a bug or PR which fixes a bug type/build Anything related to the build process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acconrad @ColinFrick @y0hami