Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sidebar] closable:false does completely prevent manual closing aswell #467

Closed
lubber-de opened this issue Feb 8, 2019 · 0 comments
Closed

[Sidebar] closable:false does completely prevent manual closing aswell #467

lubber-de opened this issue Feb 8, 2019 · 0 comments
Assignees
@lubber-de
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.3

Comments

@lubber-de
Copy link
Member

Bug Report

Sidebar having setting closable:false does also prevent closing when triggered manually (for example by .sidebar('toggle')

Steps to reproduce

  1. Create a sidebar with closable:false
  2. Try to close the sidebar by JS-bahaviors

Expected result

Sidebar should close when triggering it via behavior call. It should only prevent closing when clicking somewhere else on the page as stated in the docs

Actual result

closing is preventing in all cases

Testcase

http://jsfiddle.net/xqtb1pw0

This is a regression since #335

Version

2.7.2
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels Feb 8, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Feb 8, 2019
@lubber-de lubber-de self-assigned this Feb 8, 2019
lubber-de added a commit to lubber-de/Fomantic-UI that referenced this issue Feb 8, 2019
@lubber-de
fix(sidebar): make closable only work in clickaway event as stated in…
fd9b940 
… the docs.fixes fomantic#467
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.3 Feb 8, 2019
@lubber-de lubber-de mentioned this issue Feb 8, 2019
Merged
@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Feb 11, 2019
@y0hami y0hami closed this as completed in 316f42e Apr 2, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubber-de lubber-de

Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.3
Development

No branches or pull requests
1 participant
@lubber-de