Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toast] Add a toast module #122

Merged
merged 1 commit into from
Sep 18, 2018
Merged

[Toast] Add a toast module #122

merged 1 commit into from
Sep 18, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Sep 18, 2018

This PR adds a basic toast module, allowing to notify user of an event. It misses some features yet, but i think it's a good start already !

Try it out

Demo here

Related issues

Semantic-Org/Semantic-UI#1430
Semantic-Org/Semantic-UI#2793

@prudho prudho added type/feat Any feature requests or improvements lang/css Anything involving CSS lang/javascript Anything involving JavaScript tag/new-component New UI components state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Sep 18, 2018
@prudho prudho added this to the 2.6 milestone Sep 18, 2018
@prudho prudho self-assigned this Sep 18, 2018
@prudho prudho requested review from ColinFrick and y0hami September 18, 2018 14:48
@y0hami y0hami removed the type/feat Any feature requests or improvements label Sep 18, 2018
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/definitions/modules/toast.js Show resolved Hide resolved
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Sep 18, 2018
@y0hami y0hami merged commit 4229acb into fomantic:beta Sep 18, 2018
@Ikaer
Copy link

Ikaer commented Sep 19, 2018

Do you think, you will add some design for actions buttons ? Kind of like this:
image
(we use an old version of jquery.noty https://ned.im/noty/v2/ )
Or maybe plan some attached system to do this (like segment)

@prudho prudho deleted the toast branch September 19, 2018 06:29
@prudho
Copy link
Contributor Author

prudho commented Sep 19, 2018

Well, the toast module is pretty young, and it clearly misses some cool features yet.

This one could be a nice addition, feel free to open an issue, or eventually a PR 😉

BTW: this is an undocumented feature, because not fully tested yet, but you can add html code by the message parameter !

@romaninsh
Copy link

romaninsh commented Sep 19, 2018

Great addition. Here are some suggestions based on my previous experiences with them:

USABILITY

  • make sure you can copy-paste the text by selecting it.
  • do not hide it if the mouse hovered over it. Some users keep mouse together with their eyes
  • use newest message should be in the corner, pushing out previous message (DEFAULT). This generally is much more easier to read.

USE CASES

  • ability to add a button or a link is important as well as incorporate longer content.
  • icon should be optional
  • ability to use custom colours
  • test with modal window overlap

IDEAS

  • ideally if selecting a center position, should be proportional to the screen dimensions
  • no padding on mobile device.

@y0hami
Copy link
Member

y0hami commented Sep 19, 2018

A few of these have already been brought up so they will defiantly be added in the future.

@nasatome
Copy link

In my opinion, it is best to do something similar to https://sciactive.github.io/pnotify/

In my particular case, I love it, I do not know if you could integrate some of that type directly to Fomantic, and add a theme, to avoid reinventing the wheel.

But I repeat: I have no idea about integrations of this type.

@y0hami y0hami mentioned this pull request Sep 20, 2018
@y0hami y0hami added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo tag/new-component New UI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants