-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Toast] Add a toast module #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you think, you will add some design for actions buttons ? Kind of like this: |
Well, the toast module is pretty young, and it clearly misses some cool features yet. This one could be a nice addition, feel free to open an issue, or eventually a PR 😉 BTW: this is an undocumented feature, because not fully tested yet, but you can add html code by the |
Great addition. Here are some suggestions based on my previous experiences with them: USABILITY
USE CASES
IDEAS
|
A few of these have already been brought up so they will defiantly be added in the future. |
In my opinion, it is best to do something similar to https://sciactive.github.io/pnotify/ In my particular case, I love it, I do not know if you could integrate some of that type directly to Fomantic, and add a theme, to avoid reinventing the wheel. But I repeat: I have no idea about integrations of this type. |
This PR adds a basic toast module, allowing to notify user of an event. It misses some features yet, but i think it's a good start already !
Try it out
Demo here
Related issues
Semantic-Org/Semantic-UI#1430
Semantic-Org/Semantic-UI#2793