Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Fullscreen modal stuck to left edge of page #135

Merged
merged 1 commit into from
Sep 25, 2018
Merged

[Modal] Fullscreen modal stuck to left edge of page #135

merged 1 commit into from
Sep 25, 2018

Conversation

ColinFrick
Copy link
Member

Would be nice if someone could check the usage of .ui.fullscreen.scrolling.modal I didn't find any use-cases.

Closes #130 / Semantic-Org/Semantic-UI#6587

@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Sep 24, 2018
@ColinFrick ColinFrick requested review from prudho and y0hami September 24, 2018 11:27
@y0hami y0hami added the state/awaiting-reviews Pull requests which are waiting for reviews label Sep 24, 2018
@lubber-de lubber-de mentioned this pull request Sep 24, 2018
Closed
prudho
prudho approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After many failed tests and figured out i'm dumb by not building it... yeah, LGTM 🙃

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Sep 25, 2018
@y0hami y0hami merged commit 49d9b82 into fomantic:beta Sep 25, 2018
@ColinFrick ColinFrick deleted the fix/130 branch September 25, 2018 10:30
@ColinFrick ColinFrick added this to the 2.6.1 milestone Oct 1, 2018
@y0hami y0hami mentioned this pull request Oct 2, 2018
Merged
@ColinFrick ColinFrick mentioned this pull request Oct 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@prudho prudho prudho approved these changes

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ColinFrick @prudho @y0hami