Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Fullscreen modals are not working in IE11 #136

Merged
merged 2 commits into from
Oct 1, 2018
Merged

[Modal] Fullscreen modals are not working in IE11 #136

merged 2 commits into from
Oct 1, 2018

Conversation

ColinFrick
Copy link
Member

Increased the importance of legacy modal class definition

fullscreen modal class overrules the top / left definition of the legacy modals, which results in off-screen rendering of modals in IE11

Closes #134 / Semantic-Org/Semantic-UI#6597

fullscreen modal class overrules the top / left definition of the legacy modals, which results in off-screen rendering of modals in IE11

Closes #134 / Semantic-Org/Semantic-UI#6597
@ColinFrick ColinFrick added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS labels Sep 24, 2018
@ColinFrick ColinFrick requested review from prudho and y0hami September 24, 2018 11:27
y0hami
y0hami previously approved these changes Sep 24, 2018
@y0hami y0hami added the state/awaiting-reviews Pull requests which are waiting for reviews label Sep 24, 2018
@y0hami y0hami merged commit f255e97 into fomantic:beta Oct 1, 2018
@y0hami y0hami mentioned this pull request Oct 2, 2018
@ColinFrick ColinFrick removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 5, 2018
@ColinFrick ColinFrick deleted the fix/134 branch October 10, 2018 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants