[Calendar] Support safari to accept yyyy-mm-dd format using dashes #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
ko2in
reviewed
Aug 19, 2020
|
What looks weird? I don't see it 🤔 |
|
@ko2in Ah...the class for the calendar was missing... fixed jsfiddle here |
There are spaces around the calendar. Looks like it doesn't happen to you. |
It does 😆 ... see comment above, jsfiddle fixed here https://jsfiddle.net/lubber/s82zoc5w/2/ |
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After implementing #1462, a pure given date in
yyyy-mm-ddformat did not work in safari anymore , because safari does not handle the internal converted date ofyyyy-mm-dd 00:00:00This PR now changes the dashes to slashes, so the internal result is
yyyy/mm/dd 00:00:00, which is supported in every browserTestcase
Broken
The given date
2020-08-12results inAugust, 12, 2000https://jsfiddle.net/lubber/s82zoc5w/
Fixed
The given date
2020-08-12correctly results inAugust, 12, 2020as in every other browser alreadyhttps://jsfiddle.net/lubber/s82zoc5w/2/
Screenshots
Broken
Fixed
Closes
#1462 (comment)