Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toast] fix position for top and bottom centered container #167

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

lubber-de
Copy link
Member

Description

On scrolling body content the top center or bottom center positioning was broken

@lubber-de lubber-de changed the title [Toas] fix position for top and bottom centered container [Toast] fix position for top and bottom centered container Oct 12, 2018
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 12, 2018
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit cba9a6e into fomantic:beta Oct 15, 2018
y0hami pushed a commit that referenced this pull request Oct 15, 2018
@lubber-de lubber-de deleted the fix/toast_center_position branch October 15, 2018 07:50
@lubber-de lubber-de restored the fix/toast_center_position branch October 15, 2018 07:50
@lubber-de
Copy link
Member Author

@hammy2899 I am confused... github says here, you reverted the commit, but in beta it's still commited (which is fine 😄) and i don't see a reason for a revert. I also cannot find the revert-commit in the git log anywhere

@y0hami
Copy link
Member

y0hami commented Oct 15, 2018

@lubber-de Just ignore it, we are starting to squash commits before we merge and I accidentally hit enter while squashing without changing the commit message and I tried to cancel but failed 😄

@lubber-de lubber-de deleted the fix/toast_center_position branch October 15, 2018 08:02
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 15, 2018
@y0hami y0hami mentioned this pull request Oct 17, 2018
@lubber-de lubber-de added this to the 2.6.3 milestone Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants