[Dropdown] Issues with clearable
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck' event to clear icon independent of the on option closes #171 / Semantic-Org/Semantic-UI#6617 / Semantic-Org/Semantic-UI#6594
ColinFrick
added
type/bug
ColinFrick
added
the
state/awaiting-reviews
prudho
approved these changes
Oct 14, 2018
Closed
y0hami
approved these changes
Oct 15, 2018
y0hami
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were still some left overs from the SUI clear icon.
Additionally the click event was only attached if the 'on' option was 'click'.
Testcase
https://jsfiddle.net/Korinu/gapkb8o0/
Closes
#171 / Semantic-Org/Semantic-UI#6617 / Semantic-Org/Semantic-UI#6594