Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Fix group icon corner positions #183

Merged
merged 1 commit into from
Oct 17, 2018
Merged

[Icon] Fix group icon corner positions #183

merged 1 commit into from
Oct 17, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Oct 17, 2018

Screenshot

Before :
c0738744c365befeb43cb160f058d65c.png
After:
27b2d65bad48b312b17d3820f6ae06b3.png

Closes

#182

@prudho prudho added lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Oct 17, 2018
@prudho prudho added this to the 2.6.3 milestone Oct 17, 2018
@prudho prudho self-assigned this Oct 17, 2018
@y0hami y0hami added the type/bug Any issue which is a bug or PR which fixes a bug label Oct 17, 2018
y0hami
y0hami previously approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de
Copy link
Member

You have pushed into the calendar branch...nevertheless, the calender changes are approved anyway

ColinFrick
ColinFrick previously approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prudho prudho dismissed stale reviews from ColinFrick and y0hami via 3829c6b October 17, 2018 12:18
@prudho prudho force-pushed the fix-group-icon-corner-positions branch from 760cdd2 to 3829c6b Compare October 17, 2018 12:18
y0hami
y0hami approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lubber-de
lubber-de approved these changes Oct 17, 2018
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit aeed770 into fomantic:beta Oct 17, 2018
@y0hami y0hami mentioned this pull request Oct 17, 2018
Merged
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 24, 2018
@prudho prudho deleted the fix-group-icon-corner-positions branch April 11, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick left review comments

Assignees

@prudho prudho

Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@prudho @lubber-de @ColinFrick @y0hami