fix(step): unnecessary semicolon breaks webpack build #2028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
lang/css
lubber-de
added
type/bug
exoego
approved these changes
Jul 25, 2021
ninjascribble
added a commit
to LiquidPlanner/Semantic-UI-LESS
that referenced
this pull request
Jan 22, 2022
|
@lubber-de Any chance this can be released as a patch? |
|
@lubber-de @hammy2899 Could this also be applied to the less package? It's still based on 2.8.8 and experience the same issue with webpack5. Thank you. |
hcomnetworkers
added a commit
to hcomnetworkers/fomantic-ui-less
that referenced
this pull request
May 5, 2022
|
@lubber-de Can we get an update on when this will be merged into the main repo (and subsequently the -css distribution)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A typo breaks usage of webpack. Caused by a double semicolon in a font face description (which is tolerated by browsers)
Testcase
See #2027
Closes
#2027
#2135
#2323
#2379