feat(accordion): pure css, inverted, basic, right, tree, nested fixes #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
This was referenced Jan 7, 2022
lubber-de
added
the
state/awaiting-docs
lubber-de
changed the title
lubber-de
changed the title
exoego
approved these changes
Jan 8, 2022
lubber-de
changed the title
lubber-de
removed
the
state/awaiting-reviews
lubber-de
added a commit
that referenced
this pull request
Jan 8, 2022
Some content inside toasts should remain clickable without closing the toast. (even if closeOnClick is true) While this was already hardcoded for a tags if fails for possible other tags like accordion or details (Especially when used together with the new #2197 😉 ) The previously hardcoded selector is not a customizable classname setting. Btw: input is not needed to be set here, because any kind of input inside a toast will already set the whole toast to not closing when clicked (because it is expected to be clicked into the input fields). The new setting here is supposed for elements which can be clicked, but are not expected to.
|
Docs added by fomantic/Fomantic-UI-Docs#334 |
lubber-de
added
state/has-docs
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
Mar 9, 2022
Added example for compact and very compact variants as of fomantic/Fomantic-UI#2051 Added examples for tree, pure css, basic styled and right icon accordion as of fomantic/Fomantic-UI#2197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR enhances the accordion module:
invertedstyled varianttreevariant (for proper indentation which a tree view needs) (also works as CSS only!)right dropdown iconvariant, to be able to place the dropdown icon to the right (just as in accordion menu already). Usefull for example when used insidemessagetitleorcontentelements inside an accordion which are supposed to be parts of different elementsbasic styledvariant which is equal to styled for title handling only (so no borders and always transparent background)Testcase
https://jsfiddle.net/lubber/4k5y0cjL/38/
Screenshots
Closes
#2278
Semantic-Org/Semantic-UI#2790
Semantic-Org/Semantic-UI#4928
Semantic-Org/Semantic-UI#5238
Semantic-Org/Semantic-UI#5330
Semantic-Org/Semantic-UI#6578
Semantic-Org/Semantic-UI#7048