Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): use Date.now() instead of new Date().getTime() #2606

Merged
merged 1 commit into from
Dec 12, 2022
Merged

feat(lint): use Date.now() instead of new Date().getTime() #2606

merged 1 commit into from
Dec 12, 2022

Conversation

mvorisek
Copy link
Contributor

Modernize code using eslint advisory introduced in GH-2596. This PR focuses on fixing unicorn/prefer-date-now rule.

Needs #2602 merged first.

@lubber-de
Copy link
Member

Please resolve conflicts

lubber-de
lubber-de approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de changed the title Use Date.now() instead of new Date().getTime() feat(lint): use Date.now() instead of new Date().getTime() Dec 12, 2022
@lubber-de lubber-de merged commit e658be3 into fomantic:develop Dec 12, 2022
@lubber-de lubber-de added this to the 2.9.1 milestone Dec 12, 2022
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript type/lint eslint / stylelint related changes only labels Dec 12, 2022
@mvorisek mvorisek deleted the date_now branch December 12, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@exoego exoego Awaiting requested review from exoego

@y0hami y0hami Awaiting requested review from y0hami

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements type/lint eslint / stylelint related changes only
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @lubber-de