fix(menu): labeled right menu icon size #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
icons inside "right menu" of a "labeled menu" were not properly displayed since #111
As a labeled menu can contain dropdowns with themselves can also contain a right menu, we have to be careful of nested selectors here. That's why i did not simply revert the original patch (and we would need to remove and test losts of !important settings which most probably breaks a lot of other use cases)
Testcase
Remove CSS to see the issue
https://jsfiddle.net/lubber/6hf9zxuw/4/
Screenshots
Before
After
Closes
#2653